Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2363): update text cropping docs #409

Merged
merged 6 commits into from
Oct 13, 2022

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2363

What

  • updated the Text Crop section in docs for more clarity

image

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed labels Oct 11, 2022
@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Oct 12, 2022
@evgenitsn evgenitsn merged commit 172702f into main Oct 13, 2022
@evgenitsn evgenitsn deleted the docs/PPDSC-2363-update-text-cropping-docs branch October 13, 2022 12:35
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants