Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2427): draft release notes #403

Merged
merged 10 commits into from
Oct 11, 2022
Merged

docs(PPDSC-2427): draft release notes #403

merged 10 commits into from
Oct 11, 2022

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Oct 7, 2022 •
edited
Loading

PPDSC-2427

What

  1. Background - draft releases are not shown on website
  2. What did you do - added access token to github request so that it can fetch draft releases.
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Oct 7, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2427-draft-release-notes
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2427-draft-release-notes/storybook

@mutebg mutebg marked this pull request as ready for review October 10, 2022 06:16
@mutebg mutebg added the ready for review Please assist in getting this reviewed label Oct 10, 2022
Xin00163
Xin00163 previously approved these changes Oct 10, 2022
View reviewed changes
baburay23
baburay23 previously approved these changes Oct 11, 2022
View reviewed changes
@mutebg mutebg dismissed stale reviews from baburay23 and Xin00163 via c328ba3 October 11, 2022 08:50
@mutebg mutebg requested review from Xin00163 and baburay23 October 11, 2022 08:50
mstuartf
mstuartf approved these changes Oct 11, 2022
View reviewed changes
site/utils/release-notes/functions.ts
@@ -33,6 +41,8 @@ export const addChangeLevelToReleases: (
...prev,
{
...next,
// when the release is draft publish date is null
published_at: next.published_at || next.created_at,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@mutebg mutebg merged commit 9eec6a0 into main Oct 11, 2022
@mutebg mutebg deleted the docs/PPDSC-2427-draft-release-notes branch October 11, 2022 09:46
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@mutebg
docs(PPDSC-2427): draft release notes (#403)
060fba9 
* fix(PPDSC-2427): fetch  draft release notes

* docs(PPDSC-2427): update tests

* docs(PPDSC-2427): fix types

* docs(PPDSC-2427): update types

* docs(PPDSC-2427): fix unit tests

* docs(PPDSC-2427): add comment

* docs(PPDSC-2427): export textarea component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstuartf mstuartf mstuartf approved these changes

@Xin00163 Xin00163 Xin00163 approved these changes

@jps jps Awaiting requested review from jps

@pdimova pdimova Awaiting requested review from pdimova

@Vanals Vanals Awaiting requested review from Vanals

@evgenitsn evgenitsn Awaiting requested review from evgenitsn

@Srinivasan-Ramasamy Srinivasan-Ramasamy Awaiting requested review from Srinivasan-Ramasamy

@baburay23 baburay23 Awaiting requested review from baburay23

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mutebg @newskit-engineering @Xin00163 @mstuartf @baburay23