Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(PPDSC-2458): chore/ppds-2458-release-fix #398

Merged
merged 2 commits into from
Oct 5, 2022
Merged

chore(PPDSC-2458): chore/ppds-2458-release-fix #398

merged 2 commits into from
Oct 5, 2022

Conversation

baburay23
Copy link
Contributor

@baburay23 baburay23 commented Oct 4, 2022 •
edited
Loading

PPDSC-2458

What

  1. Background - the consent modal pops up on prod which breaks tests. We realised a different cookie had been added by sourcepoint. We changed the cookie however on mobile view the cookie id still might change and again this breaks some mobile cypress tests. So for now we have used cy.acceptCookieBanner(); on mobile, this makes the test pass. Will write a follow up ticket to have a deeper look into this
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2458-release-fix
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2458-release-fix/storybook

Xin00163
Xin00163 previously approved these changes Oct 4, 2022
View reviewed changes
@baburay23 baburay23 changed the title chore(PPDSC-2458): chore/ppds-2458-added-new-cookie chore(PPDSC-2458): chore/ppds-2458-release-fix Oct 4, 2022
mstuartf
mstuartf previously approved these changes Oct 4, 2022
View reviewed changes
@baburay23 baburay23 dismissed stale reviews from mstuartf and Xin00163 via 3c17378 October 4, 2022 20:00
@baburay23 baburay23 added the ready for review Please assist in getting this reviewed label Oct 4, 2022
@baburay23 baburay23 merged commit fc8dec2 into main Oct 5, 2022
@baburay23 baburay23 deleted the chore/PPDSC-2458-release-fix branch October 5, 2022 08:31
baburay23 added a commit that referenced this pull request Oct 6, 2022
@baburay23
chore(PPDSE-2432): Revert "chore(PPDSC-2458): chore/ppds-2458-release…
e62289e 
…-fix (#398)"

This reverts commit fc8dec2.
baburay23 added a commit that referenced this pull request Oct 10, 2022
@baburay23
Chore/ppdse 2462 release fix with local storage (#401)
cfb0a65 
* chore(PPDSE-2432): Revert "chore(PPDSC-2458): chore/ppds-2458-release-fix (#398)"

This reverts commit fc8dec2.

* chore(PPDSE-2462): added local storage json

* chore(PPDSE-2462): rmvd actions to test

* chore(PPDSE-2462): testing prod?

* chore(PPDSE-2462): testing prod config yml

* chore(PPDSE-2462): testing prod config yml part 2

* chore(PPDSE-2462): testing prod config yml part 3

* chore(PPDSE-2462): revert

* chore(PPDSE-2462): not space

* chore(PPDSE-2462): added back ternary

* chore(PPDSE-2462): test-delete consent-request

* chore(PPDSE-2462): test-deleted json jargon
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@baburay23
chore(PPDSC-2458): chore/ppds-2458-release-fix (#398)
e6faa52 
* chore(PPDSC-2458): chore/ppds-2458-added-new-cookie

* chore(PPDSC-2458): chore/ppds-2458-added-new-acceptcookiebanner
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@baburay23
Chore/ppdse 2462 release fix with local storage (#401)
386aa97 
* chore(PPDSE-2432): Revert "chore(PPDSC-2458): chore/ppds-2458-release-fix (#398)"

This reverts commit fc8dec2.

* chore(PPDSE-2462): added local storage json

* chore(PPDSE-2462): rmvd actions to test

* chore(PPDSE-2462): testing prod?

* chore(PPDSE-2462): testing prod config yml

* chore(PPDSE-2462): testing prod config yml part 2

* chore(PPDSE-2462): testing prod config yml part 3

* chore(PPDSE-2462): revert

* chore(PPDSE-2462): not space

* chore(PPDSE-2462): added back ternary

* chore(PPDSE-2462): test-delete consent-request

* chore(PPDSE-2462): test-deleted json jargon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutebg mutebg mutebg approved these changes

@evgenitsn evgenitsn evgenitsn approved these changes

@Xin00163 Xin00163 Xin00163 left review comments

@mstuartf mstuartf mstuartf left review comments

@jps jps Awaiting requested review from jps

@pdimova pdimova Awaiting requested review from pdimova

@Vanals Vanals Awaiting requested review from Vanals

@Srinivasan-Ramasamy Srinivasan-Ramasamy Awaiting requested review from Srinivasan-Ramasamy

Assignees
No one assigned
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@baburay23 @newskit-engineering @mutebg @evgenitsn @Xin00163 @mstuartf