Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSC-2136): add accessibility tests for newskit dark theme #389

Merged

Conversation

evgenitsn
Copy link
Contributor

@evgenitsn evgenitsn commented Sep 30, 2022

PPDSC-2136

What

  1. Background - we have to test the dark theme for accessibility (colour contrast)
  2. What did you do - added a way of running the a11y tests in both light and dark theme.
  3. What does the reviewers should expect - running the e2e tests, the a11y set of tests should include both light and dark theme and all tests should pass.

How to test:

Run locally yarn e2e:build && yarn e2e:serve and then in a separate terminal run yarn e2e:comps and start the a11y set of tests, or check if the CI e2e tests are ok.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed feature This change contains a new feature labels Sep 30, 2022
e2e/index.tsx Show resolved Hide resolved
e2e/tests.tsx Show resolved Hide resolved
mutebg
mutebg previously approved these changes Sep 30, 2022
Xin00163
Xin00163 previously approved these changes Oct 3, 2022
@evgenitsn evgenitsn dismissed stale reviews from Xin00163 and mutebg via d1739f0 October 3, 2022 11:07
@evgenitsn evgenitsn merged commit 25ad7e9 into main Oct 3, 2022
@evgenitsn evgenitsn deleted the chore/PPDSC-2136-add-accessibility-tests-for-newskit-dark branch October 3, 2022 11:45
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* chore(PPDSC-2136): add accessibility tests for newskit dark theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants