Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2357): Update on transition presets doc table #388

Merged

Conversation

Srinivasan-Ramasamy
Copy link
Contributor

@Srinivasan-Ramasamy Srinivasan-Ramasamy commented Sep 28, 2022

PPDSC-2357

What

  1. Added maxHeightChange transition presets to table - http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2357-update-transition-preset-doc/theme/presets/transition-presets/#predefined-transition-presets

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • [] The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

image

Who should review this PR:

How to test:

URL: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2357-update-transition-preset-doc/theme/presets/transition-presets/#predefined-transition-presets

@Srinivasan-Ramasamy Srinivasan-Ramasamy added the docs Improvements or additions to documentation label Sep 28, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy added the ready for design review Please assist in getting this reviewed label Sep 28, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Sep 28, 2022
@Srinivasan-Ramasamy
Copy link
Contributor Author

Thanks @baburay23 and @evgenitsn for taking the time to review 👍

@Srinivasan-Ramasamy Srinivasan-Ramasamy merged commit fbefa45 into main Sep 29, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy deleted the docs/PPDSC-2357-update-transition-preset-doc branch September 29, 2022 04:45
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants