-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PPDSC-2312): audio player test improvements #373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main issues: - Player sometimes still in loading state when snapshot taken. - Arbitrary waits. - Buffered amount changes, making tests flaky. - Animations making screenshots inconsistent. - Time elapsed in autoplay tests not consistent. Fixes (to avoid ignore regions in tests): - Make sure all players in a test story are loaded before taking the snapshot using oncanplay event. - Prefetch src for all players so that content is fully buffered. Add separate tests for loading / unbuffered state. - Disable CSS animations to make screenshots consistent. - Remove visual tests for autoplay behaviour as this is not necessary. Also remove duplicate autoplay story. - Remove all arbitrary waits and ignore regions in tests.
You can preview these changes on: |
mutebg
approved these changes
Sep 14, 2022
Vanals
approved these changes
Sep 14, 2022
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
* fix(PPDSC-2312): audio player test improvements Main issues: - Player sometimes still in loading state when snapshot taken. - Arbitrary waits. - Buffered amount changes, making tests flaky. - Animations making screenshots inconsistent. - Time elapsed in autoplay tests not consistent. Fixes (to avoid ignore regions in tests): - Make sure all players in a test story are loaded before taking the snapshot using oncanplay event. - Prefetch src for all players so that content is fully buffered. Add separate tests for loading / unbuffered state. - Disable CSS animations to make screenshots consistent. - Remove visual tests for autoplay behaviour as this is not necessary. Also remove duplicate autoplay story. - Remove all arbitrary waits and ignore regions in tests. * fix(PPDSC-2312): correct visual test check * fix(PPDSC-2312): fix e2e test errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2312
What
Main issues:
Fixes (to avoid ignore regions in tests):
All AudoPlayer and AudioPlayerComposable visual tests should have no arbitrary waits or ignore regions and should consistently pass.
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: