Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPNKD-554): update website copy guides section #372

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

TomPerryUX
Copy link
Contributor

PPNKD-554

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn changed the title Docs/ppnkd 554 update website copy guides section docs:(PPNKD-554): update website copy guides section Sep 12, 2022
@evgenitsn evgenitsn changed the title docs:(PPNKD-554): update website copy guides section docs(PPNKD-554): update website copy guides section Sep 12, 2022
@baburay23 baburay23 merged commit d62b8ab into main Sep 12, 2022
@baburay23 baburay23 deleted the docs/PPNKD-554-update-website-copy-guides-section branch September 12, 2022 14:26
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* docs(PPNKD-554): section copy changes

* docs(PPNKD-554): contact us copy changes

* docs(PPNKD-554): fix break lines for links

Co-authored-by: James Spencer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants