Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2413): textfield and select spacing issue #367

Merged
merged 25 commits into from
Sep 12, 2022

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Sep 8, 2022

PPDSC-2413

What

  1. Background - why this is needed
  2. What did you do:
    2.1. Fixed logical props issue in Select and TextField in which padding was applied to the parent, not to the actual input/select element
    Screenshot 2022-09-01 at 16 39 59

2.2. Fixed overrides on SelectButton, they did not work correctly, since the overrides prop were passing in correctly

2.3. Fixed spacing issue in TextField in which the input did not take 100% height of its parent
Screenshot 2022-09-01 at 16 39 00

P.S. In both cases the red border outlines the dimension of the HTML input, which is way smaller than the div container.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the fix This change fixes a bug label Sep 8, 2022
@mutebg mutebg marked this pull request as ready for review September 8, 2022 11:50
@mutebg mutebg added the ready for review Please assist in getting this reviewed label Sep 8, 2022
@mutebg mutebg merged commit 714a7f3 into main Sep 12, 2022
@mutebg mutebg deleted the fix/PPDSC-2413-textfield-select-spacing-issue branch September 12, 2022 10:47
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* feat(PPDSC-2244): fix issue in text-field

* feat(PPDSC-2244): fix types

* feat(PPDSC-2244): add text-area

* feat(PPDSC-2244): snapshots

* feat(PPDSC-2244): fix storybook-case title

* feat(PPDSC-2244): fix select logical props and overrides

* feat(PPDSC-2244): fix types

* feat(PPDSC-2244): update types

* feat(PPDSC-2244): cleanup

* feat(PPDSC-2244): cleanup

* feat(PPDSC-2244): add form validation

* feat(PPDSC-2244): fix snapshots

* feat(PPDSC-2244): add unit tets and coverage

* feat(PPDSC-2244): update snapshots

* feat(PPDSC-2244): update snapshots

* feat(PPDSC-2244): update snapshots

* feat(PPDSC-2244): cleanup

* feat(PPDSC-2244): cleanup 2

* feat(PPDSC-2244): snapshots

* feat(PPDSC-2244): fix types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants