-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PPDSC-2413): textfield and select spacing issue #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can preview these changes on: |
baburay23
approved these changes
Sep 9, 2022
Srinivasan-Ramasamy
approved these changes
Sep 9, 2022
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
* feat(PPDSC-2244): fix issue in text-field * feat(PPDSC-2244): fix types * feat(PPDSC-2244): add text-area * feat(PPDSC-2244): snapshots * feat(PPDSC-2244): fix storybook-case title * feat(PPDSC-2244): fix select logical props and overrides * feat(PPDSC-2244): fix types * feat(PPDSC-2244): update types * feat(PPDSC-2244): cleanup * feat(PPDSC-2244): cleanup * feat(PPDSC-2244): add form validation * feat(PPDSC-2244): fix snapshots * feat(PPDSC-2244): add unit tets and coverage * feat(PPDSC-2244): update snapshots * feat(PPDSC-2244): update snapshots * feat(PPDSC-2244): update snapshots * feat(PPDSC-2244): cleanup * feat(PPDSC-2244): cleanup 2 * feat(PPDSC-2244): snapshots * feat(PPDSC-2244): fix types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2413
What
2.1. Fixed logical props issue in Select and TextField in which padding was applied to the parent, not to the actual input/select element
2.2. Fixed overrides on SelectButton, they did not work correctly, since the overrides prop were passing in correctly
2.3. Fixed spacing issue in TextField in which the input did not take 100% height of its parent
![Screenshot 2022-09-01 at 16 39 00](https://user-images.githubusercontent.com/3543332/187928141-000af542-d61e-407f-8883-ad40d23ac745.png)
P.S. In both cases the red border outlines the dimension of the HTML input, which is way smaller than the div container.
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: