chore(PPDSC-2280): chore-ppdse-2280-added prevent default #366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2280
What
this had some weird behaviour the pp modal would show but the page would then refresh and go to
"components/overview"
and the PP modal would disappear.I found that the href being passed in the
LinkStandlone
component was the problem. I did some research and ended up addingevent.preventDefault();
this stops the page from refreshing when and just displays the PP modal as expected whatever page i am on in the site._document.tsx
and commented out the line below. I think in order to test you might have to do the sameI have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: