feat(PPDSC-2396): update no pointer distance for the tooltip and popover components #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview these changes on: |
jannuk59
requested review from
jps,
Xin00163,
pdimova,
baburay23,
mutebg,
Vanals,
evgenitsn and
Srinivasan-Ramasamy
as code owners
evgenitsn
requested changes
Sep 12, 2022
|
Can you please update the PR name to follow the convention? |
jannuk59
changed the title
jannuk59
changed the title
mutebg
approved these changes
Sep 13, 2022
evgenitsn
approved these changes
Sep 13, 2022
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
…ver components (#365) * feat(PPDSC-2396): updated customizable distance when there is no pointer * feat(PPDSC-2396): removed the example variable * feat(PPDSC-2396): updated docs * feat(PPDSC-2396): simplyfied the condition * feat(PPDSC-2396): updating snapshots * feat(PPDSC-2396): adding up the storybook scenario * feat(PPDSC-2396): tooltip and popover storybook scenarios * feat(PPDSC-2396): updated token space0 to space000 Co-authored-by: Ravindren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2326
...(distance ? [offset(distance)] : []),to set the distance when there is noPointer.'space020'TO DO
Check whether we can set the customisable distance when we have noPointer for the
TooltipandPopovercomponentsI have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: