-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(PPDSC-2289): Text block documentation #363
docs(PPDSC-2289): Text block documentation #363
Conversation
You can preview these changes on: |
'If provided, this overrides the typography preset applied to the text block.', | ||
}, | ||
], | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TextBlock now supports LogicalProps. Could we please add these to the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Xin00163m, updated the changes. Please review it once.
Thanks @mstuartf and @Xin00163, @baburay23 for taking the time to review 👍 |
* docs(PPDSC-2289): Text block documentation ui.
PPDSC-2289
What
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test:
URL: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2289-text-block-documentation/components/text-block/