Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSE-2397): chore-ppdse-2397-search-mobile-menu #362

Merged
merged 5 commits into from
Sep 7, 2022

Conversation

baburay23
Copy link
Contributor

@baburay23 baburay23 commented Sep 6, 2022

PPDSC-2397

What

  1. Background - when you are on mobile and you click the menu and then click the search icon the search input drops down.
  2. What did you do- After speaking to design i have removed the Search icon when the menu is open on Mobile. The search icon should only show when the menu is closed.
  3. What does the reviewers should expect- bug now fixed by removing search icon when menu is open

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@baburay23 baburay23 changed the title chore(PPDSE-2397): chore-ppdse-2397-added prop chore(PPDSE-2397): chore-ppdse-2397-search-mobile-menu Sep 6, 2022
@baburay23 baburay23 added the ready for review Please assist in getting this reviewed label Sep 6, 2022
@Srinivasan-Ramasamy
Copy link
Contributor

Quick and interesting fix 👍

@baburay23 baburay23 merged commit d95f16d into main Sep 7, 2022
@baburay23 baburay23 deleted the chore/PPDSE-2397-searchicon-on-mobile-menu branch September 7, 2022 09:09
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* chore(PPDSE-2397): chore-ppdse-2397-added prop

* chore(PPDSE-2397): chore-ppdse-2397-wrapped icon button instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants