Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(PPDSC-2358): removed loading state for Tag and Flag components #359

Merged
merged 16 commits into from
Sep 13, 2022
Merged

chore(PPDSC-2358): removed loading state for Tag and Flag components #359

merged 16 commits into from
Sep 13, 2022

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2358

What

  1. Background - why this is needed
  • Tag and Flag shouldn't have loading state
  1. What did you do
  • Removed loading prop from both components
  1. What does the reviewers should expect
  • Flag and Tag shouldn't have loading prop

I have done:

  • [] Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed feature This change contains a new feature labels Sep 2, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2358-removed-loading-state-for-tag-and-flag-components
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2358-removed-loading-state-for-tag-and-flag-components/storybook

Xin00163
Xin00163 reviewed Sep 5, 2022
View reviewed changes
src/audio-player-composable/__tests__/__snapshots__/audio-player-composable.test.tsx.snap Outdated
@@ -6657,9 +6657,9 @@ exports[`Audio Player Composable renders with TimeDisplay label overrides 1`] =
-moz-appearance: none;
-ms-appearance: none;
appearance: none;
background-color: #D5E0FC;
background-color: #3358CC;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2022-09-05 at 10 55 35
The loading button doesn't look right probably due to changes here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I've made some changes to the button/styled.ts, loading looks good now.

@evgenitsn evgenitsn added WIP Work in progress and removed ready for review Please assist in getting this reviewed labels Sep 8, 2022
@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed WIP Work in progress labels Sep 8, 2022
@evgenitsn evgenitsn merged commit 242fe25 into main Sep 13, 2022
@evgenitsn evgenitsn deleted the chore/PPDSC-2358-removed-loading-state-for-tag-and-flag-components branch September 13, 2022 11:49
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@evgenitsn
chore(PPDSC-2358): removed loading state for Tag and Flag components (#…
471d78d 
…359)

* chore(PPDSC-2358): removed loading state for Tag and Flag components

* chore(PPDSC-2358): fix loading state

* chore(PPDSC-2358): update buttons disabled state

* chore(PPDSC-2358): revert changes

* chore(PPDSC-2358): missed revert

* chore(PPDSC-2358): remove flag and tag loading state

* chore(PPDSC-2358): update Tag types

* chore(PPDSC-2358): update Tag types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xin00163 Xin00163 Xin00163 left review comments

@mstuartf mstuartf mstuartf approved these changes

@mutebg mutebg mutebg approved these changes

@jps jps Awaiting requested review from jps

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@Vanals Vanals Awaiting requested review from Vanals

@Srinivasan-Ramasamy Srinivasan-Ramasamy Awaiting requested review from Srinivasan-Ramasamy

Assignees
No one assigned
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evgenitsn @newskit-engineering @mutebg @Xin00163 @mstuartf