Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2336): chore-ppdse-2336-added NextLink added to site #356

Merged
merged 6 commits into from
Sep 2, 2022
Merged

docs(PPDSC-2336): chore-ppdse-2336-added NextLink added to site #356

merged 6 commits into from
Sep 2, 2022

Conversation

baburay23
Copy link
Contributor

@baburay23 baburay23 commented Aug 31, 2022 •
edited
Loading

PPDSC-2236

What

  1. Background - when you move between pages it would turn to light mode first then dark, in site-header and sidebar
  2. What did you do-wrapped MenuItem in LinkNext
  3. What does the reviewers should expect- you can now navigate between pages in dark mode and the page will remain in dark mode.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Aug 31, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2336-update-nextlink
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2336-update-nextlink/storybook

@baburay23 baburay23 added the ready for review Please assist in getting this reviewed label Sep 1, 2022
Srinivasan-Ramasamy
Srinivasan-Ramasamy approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@Srinivasan-Ramasamy Srinivasan-Ramasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work 👍

@baburay23 baburay23 merged commit d77b589 into main Sep 2, 2022
@baburay23 baburay23 deleted the docs/PPDSC-2336-update-nextlink branch September 2, 2022 10:41
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@baburay23
docs(PPDSC-2336): chore-ppdse-2336-added NextLink added to site (#356)
a1dd48d 
* docs(PPDSC-2336): chore-ppdse-2336-added Link site header/mobile

* docs(PPDSC-2336): chore-ppdse-2336-added side bar link next

* docs(PPDSC-2336): chore-ppdse-2336-added site to next eslinrt

* docs(PPDSC-2336): chore-ppdse-2336-removed substring

* docs(PPDSC-2336): chore-ppdse-2336-updated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutebg mutebg mutebg approved these changes

@Srinivasan-Ramasamy Srinivasan-Ramasamy Srinivasan-Ramasamy approved these changes

@jps jps Awaiting requested review from jps

@Xin00163 Xin00163 Awaiting requested review from Xin00163

@pdimova pdimova Awaiting requested review from pdimova

@Vanals Vanals Awaiting requested review from Vanals

@evgenitsn evgenitsn Awaiting requested review from evgenitsn

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baburay23 @newskit-engineering @mutebg @Srinivasan-Ramasamy