-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PPDSC-2322): add tealiumTrack to instrumentation #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xin00163
requested review from
jps,
pdimova,
baburay23,
mutebg,
Vanals,
evgenitsn and
Srinivasan-Ramasamy
as code owners
August 26, 2022 10:34
You can preview these changes on: |
mutebg
reviewed
Sep 2, 2022
baburay23
reviewed
Sep 6, 2022
mutebg
previously approved these changes
Sep 9, 2022
baburay23
previously approved these changes
Sep 9, 2022
baburay23
approved these changes
Sep 9, 2022
mutebg
approved these changes
Sep 9, 2022
Xin00163
added a commit
that referenced
this pull request
Oct 17, 2022
* feat(PPDSC-2322): add tealiumTrack to instrumentation * fix(PPDSC-2322): address comments * fix(PPDSC-2322): data team comments * fix(PPDSC-2322): add title for text block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Improvements or additions to documentation
ready for review
Please assist in getting this reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2322
createTealiumTrackHandler
usingwindow.tealiumTrack()
instead of utag.TO DO:
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: