Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2298): NewsKit homepage update - What's New section #349

Merged
merged 20 commits into from
Sep 7, 2022
Merged

docs(PPDSC-2298): NewsKit homepage update - What's New section #349

merged 20 commits into from
Sep 7, 2022

Conversation

evgenitsn
Copy link
Contributor

@evgenitsn evgenitsn commented Aug 25, 2022 •
edited
Loading

PPDSC-2298

What

Added What's New section to the new homepage /index-new
It is fetching the latest two releases from GitHub
Updated a few link icons on the page.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:
image

After:
image

Who should review this PR:

How to test:

@evgenitsn evgenitsn added docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed labels Aug 25, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2298-newskit-homepage-update-whats-new-section
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2298-newskit-homepage-update-whats-new-section/storybook

@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Sep 2, 2022
Xin00163
Xin00163 reviewed Sep 5, 2022
View reviewed changes
site/components/homepage/whats-new/whats-new.tsx
<Block marginBlockStart="space020">
{restReleases.map(({html_url, tag_name}) => (
<Block>
<LinkStandalone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered if it would be nice to have target="_blank" so it opens a new page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I thought about it and forgot to do it. 😅 Done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why are we not making use of this?
http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2298-newskit-homepage-update-whats-new-section/about/release-notes/

But I guess just designers decision 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.. I don't know, they changed the layout of this section a few times in the process. I am going to mention that to Mike and Valeriia just to make sure but I guess we can go ahead and merge this one as it is when reviewed.

@evgenitsn evgenitsn merged commit 9516ff1 into main Sep 7, 2022
@evgenitsn evgenitsn deleted the docs/PPDSC-2298-newskit-homepage-update-whats-new-section branch September 7, 2022 13:21
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@evgenitsn
docs(PPDSC-2298): NewsKit homepage update - What's New section (#349)
665a77c 
* docs(PPDSC-2298): newskit homepage update - whats new section

* docs(PPDSC-2298): update unit test

* docs(PPDSC-2298): update UI

* docs(PPDSC-2298): update snapshots

* docs(PPDSC-2298): update spacings

* docs(PPDSC-2298): added target _blank to whats new links

* docs(PPDSC-2298): update external release link

* docs(PPDSC-2298): simplified markup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Srinivasan-Ramasamy Srinivasan-Ramasamy Srinivasan-Ramasamy approved these changes

@Xin00163 Xin00163 Xin00163 approved these changes

@jps jps Awaiting requested review from jps

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@mutebg mutebg Awaiting requested review from mutebg

@Vanals Vanals Awaiting requested review from Vanals

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evgenitsn @newskit-engineering @Xin00163 @Vanals @Srinivasan-Ramasamy