Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2263): Switch documentation #348

Merged
merged 14 commits into from
Aug 26, 2022
Merged

docs(PPDSC-2263): Switch documentation #348

merged 14 commits into from
Aug 26, 2022

Conversation

Srinivasan-Ramasamy
Copy link
Contributor

@Srinivasan-Ramasamy Srinivasan-Ramasamy commented Aug 24, 2022 •
edited
Loading

PPDSC-2263

What

  1. Switch documentation UI - http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2263-switch-documentation/components/switch/

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

URL: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2263-switch-documentation/components/switch/

@Srinivasan-Ramasamy Srinivasan-Ramasamy added docs Improvements or additions to documentation WIP Work in progress labels Aug 24, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2263-switch-documentation
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2263-switch-documentation/storybook

@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for design review Please assist in getting this reviewed and removed WIP Work in progress labels Aug 24, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for review Please assist in getting this reviewed and removed ready for review Please assist in getting this reviewed ready for design review Please assist in getting this reviewed labels Aug 25, 2022
@mutebg mutebg merged commit e9e87ae into main Aug 26, 2022
@mutebg mutebg deleted the docs/PPDSC-2263-switch-documentation branch August 26, 2022 08:53
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@Srinivasan-Ramasamy
docs(PPDSC-2263): Switch documentation (#348)
7f5f770 
* docs(PPDSC-2263): initial ui changes

* docs(PPDSC-2263): ui changes in sections

* docs(PPDSC-2263): unit test fixes

* docs(PPDSC-2263): ui fixes

* docs(PPDSC-2263): design feedback changes

* docs(PPDSC-2263): design feedback changes

* docs(PPDSC-2263): route file text changes

* docs(PPDSC-2263): unit test build fix

* docs(PPDSC-2263): unit test build fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutebg mutebg mutebg approved these changes

@baburay23 baburay23 baburay23 approved these changes

@jps jps Awaiting requested review from jps

@Xin00163 Xin00163 Awaiting requested review from Xin00163

@pdimova pdimova Awaiting requested review from pdimova

@Vanals Vanals Awaiting requested review from Vanals

@evgenitsn evgenitsn Awaiting requested review from evgenitsn

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Srinivasan-Ramasamy @newskit-engineering @mutebg @baburay23