Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2266): remove typo in video player styling #346

Merged
merged 4 commits into from
Aug 23, 2022

Conversation

mstuartf
Copy link
Contributor

PPDSC-2266

What

  1. Background - bug
  2. What did you do
  • Typo meant video player class styling was not nested under randomised emotion class names.
  • Styling was being applied (to the whole page) by the video-js and vjs-* classnames.
  • This meant that switching between themes would not always update styling. Because there was no randomised classname, the styling for a re-selected theme would not be reloaded.
  • Removed the typo and updated the snapshots.
  1. What does the reviewers should expect
  • Styling should no longer get stuck when moving between themes

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

- Typo meant video player class styling was not nested under randomised emotion class names.
- Styling was being applied (to the whole page) by the `video-js` and `vjs-*` classnames.
- This meant that switching between themes would not always update styling. Because there was no randomised classname, the styling for a re-selected theme would not be reloaded.
- Removed the typo and updated the snapshots.
@github-actions github-actions bot added the fix This change fixes a bug label Aug 22, 2022
@newskit-engineering
Copy link
Collaborator

Copy link
Contributor

@mutebg mutebg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@mstuartf mstuartf added the ready for review Please assist in getting this reviewed label Aug 23, 2022
@mstuartf mstuartf merged commit 58fad4e into main Aug 23, 2022
@mstuartf mstuartf deleted the fix/PPDSC-2266-video-player branch August 23, 2022 16:31
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
- Typo meant video player class styling was not nested under randomised emotion class names.
- Styling was being applied (to the whole page) by the `video-js` and `vjs-*` classnames.
- This meant that switching between themes would not always update styling. Because there was no randomised classname, the styling for a re-selected theme would not be reloaded.
- Removed the typo and updated the snapshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants