-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(PPDSC-1852): replace enums #340
Conversation
You can preview these changes on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was huge, I did not realise how many files we need to change to replace these enums. Good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely more than 3 points and you did a great job 👍 . One tiny comment.
site/pages/components/stack.mdx
Outdated
| 'horizontal-center' | ||
| 'horizontal-bottom' | ||
| 'horizontal-stretch'>" | ||
default="vertical" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default="vertical" | |
default="vertical-left" |
* chore(PPDSC-1852): chore-ppdse-1852-replace buttonSize with union * chore(PPDSC-1852): chore-ppdse-1852-replace buttonSize with union * chore(PPDSC-1852): chore-ppdse-1852-replace buttonSize with union * chore(PPDSC-1852): chore-ppdse-1852-replace-buttonSize-with-union * chore(PPDSC-1852): chore-ppdse-1852-replace-buttonSize-with-union * chore(PPDSC-1852): chore-ppdse-1852-replace-menuItemAlign-with-union * chore(PPDSC-1852): chore-ppdse-1852-replace-buttonSize-with-union * chore(PPDSC-1852): chore-ppdse-1852-fixed audioplayer type * chore(PPDSC-1852): chore-ppdse-1852-removed stackChild enum * chore(PPDSC-1852): chore-ppdse-1852-removed stackChild enum * chore(PPDSC-1852): removed Tagsize labelPosition enum * chore(PPDSC-1852): chore-ppdse-1852-updated slider labelposition * chore(PPDSC-1852): chore-ppdse-1852-updated src files for flow * chore(PPDSC-1852): chore-ppdse-1852-updated slider test * chore(PPDSC-1852): removed Tagsize tabIndicatorPosition enum * chore(PPDSC-1852): removed MenuItemSize enum * chore(PPDSC-1852): removed TabAlign enum * chore(PPDSC-1852): removed tabSize enum * chore(PPDSC-1852): chore-ppdse-1852-removed flow and stackD * chore(PPDSC-1852): chore-ppdse-1852-stack test passing * chore(PPDSC-1852): chore-ppdse-1852-tab align removed * chore(PPDSC-1852): chore-ppdse-1852-got rid of tab enums * chore(PPDSC-1852): chore-ppdse-1852-got rid of tab enums * chore(PPDSC-1852): chore-ppdse-1852-flagsize done * chore(PPDSC-1852): chore-ppdse-1852-buttonsize removed * chore(PPDSC-1852): chore-ppdse-1852-updated documentation * chore(PPDSC-1852): chore-ppdse-1852-updated tab documentation * chore(PPDSC-1852): chore-ppdse-1852-tests updated * chore(PPDSC-1852): chore-ppdse-1852-fixed tag size * chore(PPDSC-1852): chore-ppdse-1852-menu align moved * chore(PPDSC-1852): chore-ppdse-1852-tidied menu tests * chore(PPDSC-1852): chore-ppdse-1852-fixed stack test types * chore(PPDSC-1852): removed TabsDistribution enum * chore(PPDSC-1852): chore-ppdse-1852-fixed menu test * chore(PPDSC-1852): chore-ppdse-1852-fixed slider.mdx * chore(PPDSC-1852): chore-ppdse-1852-textfiedl done * chore(PPDSC-1852): chore-ppdse-1852-textinput done * chore(PPDSC-1852): chore-ppdse-1852-textinput done * chore(PPDSC-1852): chore-ppdse-1852-tidy up * chore(PPDSC-1852): chore-ppdse-1852-fixed mdx error * chore(PPDSC-1852): chore-ppdse-1852-fixed mdx error again * chore(PPDSC-1852): chore-ppdse-1852-added codemod back * chore(PPDSC-1852): chore-ppdse-1852-added codemod back and linted * chore(PPDSC-1852): chore-ppdse-1852-fixed merge * chore(PPDSC-1852): chore-ppdse-1852-fixed stack story * chore(PPDSC-1852): chore-ppdse-1852-tidied audioplayer types * chore(PPDSC-1852): chore-ppdse-1852-changed to lower case * chore(PPDSC-1852): chore-ppdse-1852-fixed comments * fix(PPDSC-1852): add lowercase with space to enum codemod * chore(PPDSC-1852): chore-ppdse-1852-fixed stack types * chore(PPDSC-1852): chore-ppdse-1852-updated tests * chore(PPDSC-1852): chore-ppdse-1852-updated stack.mdx Co-authored-by: Ravindren <[email protected]> Co-authored-by: Xin00163 <[email protected]>
PPDSC-1852
What
replaced enums with union types for
Just wanted to add some snapshots have been updated this is because I had to change the mapping from enums to an array so only the titles have changed. For
menu.test.tsx
it looks like there are changes however there are no visual changes because of the way tests are written the snapshots are out of place.For each test i have written I have compared the it in https://text-compare.com/
so the previous test called
Menu renders with menu items aligned at the end 1
is the exact same as the new testMenu with align renders with menu items aligned at the end vertical 1
same with
before
Menu renders with menu items aligned at the start 2
and afterMenu with align renders with menu items aligned at the start horizontal 1
are the same visually. Sorry just wanted to add this in as this threw me off originally.I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: