-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(PPDSC-2287): Grid layout documentation #335
docs(PPDSC-2287): Grid layout documentation #335
Conversation
You can preview these changes on: |
{focusOrder && ( | ||
<A11yTable columns={['Order', 'Element', 'Role']} {...focusOrder} /> | ||
)} | ||
{(focusOrder || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this change do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mstuartf for reviewing the changes.
Actually this changes wants to avoid the extra empty space below the Accessibility section:
We're conditionally rendering the block to avoid the extra space here:
To match the figma design, we've updated this condition.
* docs(PPDSC-2287): Grid layout documentation page
PPDSC-2287
What
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test:
URL: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2287-grid-layout-documentation/components/grid-layout/