Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2252): Misc updates on the site #317

Merged
merged 18 commits into from
Aug 3, 2022

Conversation

Srinivasan-Ramasamy
Copy link
Contributor

@Srinivasan-Ramasamy Srinivasan-Ramasamy commented Jul 28, 2022

PPDSC-2252

What

  1. Tabs doc page (components).
  2. Text Field & Select doc pages (components, updated column-renderer.tsx link render logic based on link with text).
  3. Related section (components).
  4. Remove the principles sections from all the foundations pages with unused images (Removed unused illustrations from static/theming/foundations/).
  5. Hided the Design Quickstart (guides) doc page.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

URL: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2252-site-misc-updates/

@Srinivasan-Ramasamy Srinivasan-Ramasamy added docs Improvements or additions to documentation WIP Work in progress labels Jul 28, 2022
@newskit-engineering
Copy link
Collaborator

@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for design review Please assist in getting this reviewed and removed WIP Work in progress labels Jul 29, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Aug 1, 2022
Copy link
Contributor

@baburay23 baburay23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a look at each change mentioned in the ticket. looks good to me!

@Srinivasan-Ramasamy
Copy link
Contributor Author

Srinivasan-Ramasamy commented Aug 3, 2022

Thanks @baburay23 and @evgenitsn for taking your time to review 👍

@Srinivasan-Ramasamy Srinivasan-Ramasamy merged commit 677174f into main Aug 3, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy deleted the docs/PPDSC-2252-site-misc-updates branch August 3, 2022 07:50
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* docs(PPDSC-2252): Misc updates on the site changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants