Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSC-2229): update storybook container styles #316

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

evgenitsn
Copy link
Contributor

@evgenitsn evgenitsn commented Jul 28, 2022

PPDSC-2229

What

Updated storybook container component with some additional padding to avoid cutting parts of the components out of screen

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

image

After:

image

Who should review this PR:

How to test:

@evgenitsn evgenitsn added the ready for review Please assist in getting this reviewed label Jul 28, 2022
Copy link
Contributor

@Srinivasan-Ramasamy Srinivasan-Ramasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@evgenitsn evgenitsn merged commit 1666002 into main Jul 29, 2022
@evgenitsn evgenitsn deleted the chore/PPDSC-2229-update-storybook-container-styles branch July 29, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants