Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2215): add forwardRef to components part 2 #315

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2215

What

  1. Background - Users should be able to use ref
  2. What did you do - Added forward ref too
  • AudioPlayerPlaybackSpeedControl
  • banner
  • banner internal
  • base floating element
  • label
  • modal
  • ordered-list
  • popover
  • standfirst
  • tabs
  • tag
  • title-bar
  • tooltip
  • unordered-list

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed feature This change contains a new feature labels Jul 27, 2022
@evgenitsn evgenitsn changed the title feat(PPDSC-2215): add forwardRef to components 2 feat(PPDSC-2215): add forwardRef to components part 2 Jul 27, 2022
Copy link
Contributor

@baburay23 baburay23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried a few components out with Tooltip looks good to me!

Copy link
Contributor

@Xin00163 Xin00163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually just saw popover is included. Awesome. Looks good!

@evgenitsn evgenitsn merged commit 580d308 into main Jul 29, 2022
@evgenitsn evgenitsn deleted the feat/PPDSC-2215-add-forwardRef-to-components-2 branch July 29, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants