-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(PPDSC-2268): Accordion documentation #292
Conversation
You can preview these changes on: |
Thanks @baburay23 and @mutebg for taking the time to review 👍 |
site/pages/components/accordion.tsx
Outdated
<br /> | ||
<br /> | ||
<Block spaceStack="space050"> | ||
<UnorderedList |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use
<UnorderedList overrides={{ paddingBlockStart: 'something', paddingBlockEnd: 'space050'}}>
instead of that block and <br />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mutebg for the review and suggestion and It's really helps on before and after elements spaces. 💯
Changes are done.
* docs(PPDSC-2268): Accordion documentation page.
PPDSC-2268
What
I have done:
I have tested manually:
Before:
SEO Considerations extra space at the bottom:
After:
Removed SEO Considerations extra space at the bottom:
Who should review this PR:
How to test:
URL: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2268-accordion-page/components/accordion/