Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(PPDSC-2292): attempt fix of develoment env #285

Merged
merged 1 commit into from
Jul 15, 2022
Merged

ci(PPDSC-2292): attempt fix of develoment env #285

merged 1 commit into from
Jul 15, 2022

Conversation

jps
Copy link
Contributor

@jps jps commented Jul 15, 2022

PPDSC-2292

What

  1. Background - attempt to fix development deployment
  2. What did you do - change if statement based on feedback from https://stackoverflow.com/a/21210966
  3. What does the reviewers should expect - single line change

@jps jps changed the title ci(PPDSC-2292): add true to conditional ci(PPDSC-2292): attempt fix of develoment env Jul 15, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2292-fix-development-deployment-attempt-1
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2292-fix-development-deployment-attempt-1/storybook

@jps jps merged commit 3b0ca8a into main Jul 15, 2022
@jps jps deleted the ci/PPDSC-2292-fix-development-deployment-attempt-1 branch July 15, 2022 07:47
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
ci(PPDSC-2292): add true to conditional (#285)
8ae5e36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbradbury tbradbury tbradbury approved these changes

@evgenitsn evgenitsn evgenitsn approved these changes

@Xin00163 Xin00163 Awaiting requested review from Xin00163

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@mutebg mutebg Awaiting requested review from mutebg

@Vanals Vanals Awaiting requested review from Vanals

@Srinivasan-Ramasamy Srinivasan-Ramasamy Awaiting requested review from Srinivasan-Ramasamy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jps @newskit-engineering @evgenitsn @tbradbury