Fix/ppdsc 2208 Fix svg previewer: remove sourcepoint and tealium in dev #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vanals
requested review from
jps,
Xin00163,
pdimova,
baburay23,
mutebg,
evgenitsn and
Srinivasan-Ramasamy
as code owners
|
You can preview these changes on: |
Vanals
changed the title
mutebg
reviewed
Jul 13, 2022
|
@mutebg also removed the e2e tests for the consent :/. I guess we can't keep them and we will be able to bring them back once the consent works on dev environment |
mutebg
approved these changes
Jul 14, 2022
Srinivasan-Ramasamy
approved these changes
Jul 14, 2022
jps
reviewed
Jul 14, 2022
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
…ev (#276) * docs(PPDSC-0000): testing permissions * docs(PPDSC-0000): removing test changed from readme * fix(PPDSC-2208): implemented conditional for tealium and sorcpoint scrip * fix(PPDSC-2208): remove scripts from dev * fix(PPDSC-2208): removing e2e tests for consent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2208
What
I have tried to remove the scripts only for the
tools/preview-illustration-exportpage creating a flag base on the page but did not work.I am then implementing the solution removing scripts on
dev. We will be able to really test it one in there but hopefully this should work. Locally the scripts were not in the DOMI have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: