feat(PPDSC-2248): structured list no icon prop when link

[evgenitsn]

PPDSC-2248

What

Added an optional noIcon prop for the <StructuredListItem/>. When applied if the item is a URL the icon on the righthand side wont show.

I have done:

• Written unit tests against changes
• Written functional tests against the component and/or NewsKit site
• Updated relevant documentation

I have tested manually:

• The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
• The screen reader reads and flows through the elements as expected.
• There are no new errors in the browser console coming from this PR.
• When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
• The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

[newskit-engineering]

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2248-structured-list-with-no-icon-when-link
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2248-structured-list-with-no-icon-when-link/storybook

[baburay23]

hey looks goof to me. i wasn't sure on the noIcon name but could not think of a better one and it does the job :D

[mutebg]

hey looks goof to me. i wasn't sure on the noIcon name but could not think of a better one and it does the job :D

What about hideIcon ?

[evgenitsn]

hey looks goof to me. i wasn't sure on the noIcon name but could not think of a better one and it does the job :D

What about hideIcon ?

@baburay23 @mutebg

Umm, I've searched the codebase for other hide or no props.

The no is used for noValidate and noCrop but these aren't things that can be hide.
On the other hand we have hideLabel, hideOverlay, hideFeedback and this icon stuff sounds more like these, so I'll update the noIcon to hideIcon.
Thanks for reviewing.

[mutebg]

hey looks goof to me. i wasn't sure on the noIcon name but could not think of a better one and it does the job :D

What about hideIcon ?

@baburay23 @mutebg

Umm, I've searched the codebase for other hide or no props.

The no is used for noValidate and noCrop but these aren't things that can be hide. On the other hand we have hideLabel, hideOverlay, hideFeedback and this icon stuff sounds more like these, so I'll update the noIcon to hideIcon. Thanks for reviewing.

Good one @evgenitsn , I knew that we used hideLabel on few places