Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2226): functionality to dismiss popover #258

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

tbradbury
Copy link
Contributor

PPDSC-2226

What

  1. Background - why this is needed - Requested functionality for Audio Player requires change to Popover so when you click outside of popover or press esc the popover closes.
  2. What did you do - Added a new prop called enableDismiss that when set to true enables the above functionality. Original idea was to have to props so that clicking outside Popover or using esc key could be enables separately. However we are using the floating-ui library where this functionality comes as a package.
  3. What should the reviewers expect - When enableDismiss set to true you can click outside of popover or press esc and popover will close

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the feature This change contains a new feature label Jul 4, 2022
@newskit-engineering
Copy link
Collaborator

@tbradbury tbradbury merged commit 0b1d44f into main Jul 5, 2022
@tbradbury tbradbury deleted the feat/PPDSC-2226-popover branch July 5, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants