feat(PPDSC-2176): feat-ppdse-2176-tooltip-updates #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baburay23
requested review from
jps,
Xin00163,
pdimova,
mutebg,
Vanals,
evgenitsn and
Srinivasan-Ramasamy
as code owners
baburay23
changed the title
|
You can preview these changes on: |
baburay23
added
ready for review
Xin00163
previously approved these changes
Jul 6, 2022
| @@ -109,6 +125,7 @@ export const StoryTooltip = () => ( | |||
| > | |||
| <Button | |||
| size={ButtonSize.Small} | |||
| // disabled | |||
mstuartf
reviewed
Jul 6, 2022
mutebg
reviewed
Jul 7, 2022
src/tooltip/tooltip.tsx
Outdated
| @@ -32,6 +32,17 @@ const ThemelessTooltip: React.FC<TooltipProps> = ({ | |||
|
|
|||
| const contentIsString = typeof content === 'string'; | |||
|
|
|||
| const showSpanWarning = (): void => { | |||
There was a problem hiding this comment.
Suggested change
| const showSpanWarning = (): void => { | |
| const showDisabledWarning = (): void => { |
mstuartf
previously approved these changes
Jul 7, 2022
mutebg
approved these changes
Jul 8, 2022
Xin00163
approved these changes
Jul 8, 2022
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
* feat(PPDSC-2176): feat-ppdse-2176-added tooltip to themecheck * feat(PPDSC-2176): feat-ppdse-2176-adding span * feat(PPDSC-2176): feat-ppdse-2176-added console warn * feat(PPDSC-2176): feat-ppdse-2176-added warn test * feat(PPDSC-2176): feat-ppdse-2176-updated warning messaget * feat(PPDSC-2176): feat-ppdse-2176-added production * feat(PPDSC-2176): feat-ppdse-2176-updated tests * feat(PPDSC-2176): feat-ppdse-2176-removed commeny * feat(PPDSC-2176): feat-ppdse-2176-updated tests * feat(PPDSC-2176): feat-ppdse-2176-changed useeffect * feat(PPDSC-2176): feat-ppdse-2176-updated useeffect * feat(PPDSC-2176): feat-ppdse-2171-chnaged func name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2176
What
`<Tooltip
content="You are not permitted to view this"
placement="right"
trigger={['focus', 'hover']} Button `
The above example will work, without using span a component with a disabled prop will not trigger user interactions so a Tooltip will not activate on normal events like hover.
I will also update the tooltip documentation here
i have also added a console.warn error so the user is alerted if the is not passed
5. What does the reviewers should expect- added a story example and test, also added Tooltip to theme checker
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: