ci(PPDSC-2084): Updating circleci/slack and bringing back all messages on failures #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vanals
requested review from
baburay23,
mutebg,
evgenitsn and
Srinivasan-Ramasamy
as code owners
|
You can preview these changes on: |
Vanals
added
ready for review
tbradbury
previously approved these changes
Jul 4, 2022
Vanals
changed the title
evgenitsn
previously approved these changes
Jul 4, 2022
tbradbury
previously approved these changes
Jul 4, 2022
evgenitsn
approved these changes
Jul 5, 2022
mstuartf
approved these changes
Jul 5, 2022
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
…s on failures (#250) * ci(PPDSC-2084): trying to test new config * ci(PPDSC-2084): using right command * ci(PPDSC-2084): adding slack notify * ci(PPDSC-2084): fixing indentation * ci(PPDSC-2084): fixing branch pattern * ci(PPDSC-2084): passing context with auth token to job * ci(PPDSC-2084): adding workflow triggered by tag * ci(PPDSC-2084): passing context to job * ci(PPDSC-2084): test failing branch * ci(PPDSC-2084): testing multu tag slack allert * ci(PPDSC-2084): testing new tag_pattern * ci(PPDSC-2084): hopefully fixing tag pattern * ci(PPDSC-2084): removed testing code * ci(PPDSC-2084): updated message * ci(PPDSC-2084): trst custom template * ci(PPDSC-2084): add column in jib * ci(PPDSC-2084): add missing column * ci(PPDSC-2084): testing * ci(PPDSC-2084): remove test code finalize template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2084
What
Updated circleci/slack orb version and its config object
Now it supports failing messages on workflows triggered by tags. As happens for our release workflows.
Created new Slack Application as suggested by the orb
I followed the guide, created a new slack application, and installed it in the Workspace. Then invited the app in our channel.
In order to work the circleci/slack needs an auth_token. I have added the slack auth token in all the circleci contexts we use.
infact different jobs uses different contexts.
I have added the SLACK_ACCESS_TOKEN in:
ncu-newskit-site-pr ncu-newskit-site-stage
ncu-newskit-site-prod
ncu-newskit-site-dev
ncu-product-platforms-context
It was available in the App slack page. I have created the app. Not sure everyone can access to the settings? we can see how to extend that potentially.
Still complains about a webhook, but not sure how/ if we should get rid of it and might create issues for other teams?
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: