feat(PPDSC-2218): added Scroll storybook scenario #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agagotowiec
added
ready for review
agagotowiec
requested review from
jps,
Xin00163,
pdimova,
baburay23,
mutebg,
Vanals,
evgenitsn and
Srinivasan-Ramasamy
as code owners
|
You can preview these changes on: |
mutebg
changed the title
evgenitsn
approved these changes
Jul 1, 2022
mutebg
suggested changes
Jul 1, 2022
Comment on lines
346
to
361
| export const StoryScrollInsideTheContainer = () => ( | ||
| <MainContainer> | ||
| <StorybookSubHeading> | ||
| Scroll elements inside the container using tab key | ||
| </StorybookSubHeading> | ||
| <Container width="250px" height="100px"> | ||
| <Scroll scrollBar controls="static" tabIndex={-1}> | ||
| <Flex> | ||
| {Array.from({length: 10}, (_, i) => ( | ||
| <Box key={getSSRId()} tabIndex={0}>{`Item ${i + 1}`}</Box> | ||
| ))} | ||
| </Flex> | ||
| </Scroll> | ||
| </Container> | ||
| </MainContainer> | ||
| ); |
There was a problem hiding this comment.
May I suggest using of Button instead of the Box, the approach can be the same as the tags story but just use the Button component instead.
mutebg
approved these changes
Jul 5, 2022
baburay23
approved these changes
Jul 6, 2022
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
…ponent-story feat(PPDSC-2218): added Scroll storybook scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2218
What
Background - why this is needed
Missing scenario in the scroll component storybook showcasing how users can scroll inside the container using tab key.
What did you do
Added a scenario to the scroll component storybook that allow the user to scroll inside of the container using the tab key.
What does the reviewers should expect
A scenario where focus moves to first interactive element inside the container and then through the other interactive elements.
I have done:
I have tested manually:
After:
Who should review this PR:
How to test:
Please check scenario 'scroll-inside-the-container-with-tab-key' in the scroll component storybook