Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PPDSC-2119): floating element motion #245

Merged
merged 7 commits into from
Jul 4, 2022
Merged

feat(PPDSC-2119): floating element motion #245

merged 7 commits into from
Jul 4, 2022

Conversation

mstuartf
Copy link
Contributor

PPDSC-2119

What

  1. Background:
  • v1 Tooltip and Popover components missing transitions
  1. What did you do:
  • Added support for transition presets to BaseFloatingElement
  • Added defaultTransition presets to Tooltip and Popover components
  • Updated tests
  • Updated Storybook scenarios
  1. What does the reviewers should expect:
  • Tooltip and Popover components should use fade transitionPreset
  • Possible to override transitionPresets for Tooltip and Popover

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

mstuartf added 3 commits June 30, 2022 08:54
@mstuartf
feat(PPDSC-2119): add floating element motion
f5fcb3c 
- Support transitionPreset in BaseFloatingElement
- Add transitionPreset to Tooltip defaults and update snaps
- Add transitionPreset to Popover defaults and update snaps
- Update theme snapshots for changes to defaults
@mstuartf
feat(PPDSC-2119): make variable names clearer
b9f9d30
@mstuartf
feat(PPDSC-2119): transition preset overrides
0ff2755 
- Add support for transitionPreset overrides to floating elements
- Update Tooltip and Popover overrides tests to include transitionPreset overrides
- Update Tooltip and Popover overrides Storybook scenarios to include transitionPreset overrides
@github-actions github-actions bot added the feature This change contains a new feature label Jun 30, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2119-floating-element-motion
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2119-floating-element-motion/storybook

mutebg
mutebg approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@mutebg mutebg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good !

@mstuartf mstuartf mentioned this pull request Jul 1, 2022
Closed
@mstuartf mstuartf merged commit a20f4b4 into main Jul 4, 2022
@mstuartf mstuartf deleted the feat/PPDSC-2119-floating-element-motion branch July 4, 2022 14:32
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@mstuartf
feat(PPDSC-2119): floating element motion (#245)
cf09617 
* feat(PPDSC-2119): add floating element motion

- Support transitionPreset in BaseFloatingElement
- Add transitionPreset to Tooltip defaults and update snaps
- Add transitionPreset to Popover defaults and update snaps
- Update theme snapshots for changes to defaults

* feat(PPDSC-2119): make variable names clearer

* feat(PPDSC-2119): transition preset overrides

- Add support for transitionPreset overrides to floating elements
- Update Tooltip and Popover overrides tests to include transitionPreset overrides
- Update Tooltip and Popover overrides Storybook scenarios to include transitionPreset overrides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutebg mutebg mutebg approved these changes

@tbradbury tbradbury tbradbury approved these changes

@jps jps Awaiting requested review from jps

@Xin00163 Xin00163 Awaiting requested review from Xin00163

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@Vanals Vanals Awaiting requested review from Vanals

@evgenitsn evgenitsn Awaiting requested review from evgenitsn

@Srinivasan-Ramasamy Srinivasan-Ramasamy Awaiting requested review from Srinivasan-Ramasamy

Assignees
No one assigned
Labels
feature This change contains a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mstuartf @newskit-engineering @mutebg @tbradbury