Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2151): add outline override examples #243

Merged
merged 4 commits into from
Jun 30, 2022

Conversation

tbradbury
Copy link
Contributor

PPDSC-2151

What

  1. Outline property has been added to components. Need to show uses how they can customise this using overrides.
  2. Adds new outline overrides stories to storybook.
  3. Components that use outline property have example of outline overrides.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the feature This change contains a new feature label Jun 29, 2022
@newskit-engineering
Copy link
Collaborator

@tbradbury tbradbury added the ready for review Please assist in getting this reviewed label Jun 29, 2022
@tbradbury tbradbury merged commit d40f53c into main Jun 30, 2022
@tbradbury tbradbury deleted the feat/PPDSC-2151-overides branch June 30, 2022 14:17
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* feat(PPDSC-2151): add outline override examples

* feat(PPDSC-2151): change ids to fix a11y tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants