Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2182): added initialTime prop and test #238

Merged
merged 8 commits into from
Jun 30, 2022

Conversation

agagotowiec
Copy link
Contributor

@agagotowiec agagotowiec commented Jun 24, 2022

PPDSC-1961

What

Added initialTime prop to the audio-player-composable to allow customers to start the audio from a specific time.
Added a new scenario in the storybook with initial props both for time and volume.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

After:
Screenshot 2022-06-24 at 14 19 50

How to test:
Please check the audio-player-with-initial-props scenario in the storybook

@github-actions github-actions bot added the feature This change contains a new feature label Jun 24, 2022
@agagotowiec agagotowiec added the ready for review Please assist in getting this reviewed label Jun 24, 2022
@agagotowiec agagotowiec changed the title feat(PPDSC-1961): added initialTime prop and test feat(PPDSC-2182): added initialTime prop and test Jun 24, 2022
Copy link
Contributor

@Srinivasan-Ramasamy Srinivasan-Ramasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Contributor

@mutebg mutebg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @agagotowiec

@agagotowiec agagotowiec merged commit 4c052ef into main Jun 30, 2022
@agagotowiec agagotowiec deleted the feat/PPDSC-1961-initial-start-point-audioPlayer branch June 30, 2022 09:18
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
…art-point-audioPlayer

feat(PPDSC-2182): added initialTime prop and test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants