Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2187): Patterns date picker and email address pages #237

Merged
merged 27 commits into from
Jun 28, 2022
Merged

docs(PPDSC-2187): Patterns date picker and email address pages #237

merged 27 commits into from
Jun 28, 2022

Conversation

Srinivasan-Ramasamy
Copy link
Contributor

@Srinivasan-Ramasamy Srinivasan-Ramasamy commented Jun 24, 2022 •
edited
Loading

PPDSC-2187

What

  1. Date picker page UI changes. - http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2187-patterns-datepicker-emailaddress-pages/patterns/forms/date-picker/
  2. Email address page UI changes. - http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2187-patterns-datepicker-emailaddress-pages/patterns/forms/email-address/
  3. Fix: Border page is missing in routes.ts file. - http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2187-patterns-datepicker-emailaddress-pages/theme/foundation/borders/

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

Srinivasan-Ramasamy and others added 16 commits June 17, 2022 14:41
@Srinivasan-Ramasamy
docs(PPDSC-2186): initial ui changes
c87f829
@Srinivasan-Ramasamy
docs(PPDSC-2186): ui changes on sections
da20686
@Srinivasan-Ramasamy
docs(PPDSC-2186): ui section update
ddd9c0e
@Srinivasan-Ramasamy
docs(PPDSC-2186): address page mobile view space adjustment
275e218
@Srinivasan-Ramasamy
docs(PPDSC-2186): dob page ui changes with unit test fix
e6eb2d1
@Srinivasan-Ramasamy
docs(PPDSC-2186): build fix
38980c1
@Srinivasan-Ramasamy
docs(PPDSC-2186): build fix
5be0b1a
@Srinivasan-Ramasamy
docs(PPDSC-2186): build fix
a5291bd
@Srinivasan-Ramasamy
Merge branch 'main' into docs/PPDSC-2186-patterns-address-dob-pages
37dda31
@Srinivasan-Ramasamy
docs(PPDSC-2186): created utils styled common file
954322c
@Srinivasan-Ramasamy
docs(PPDSC-2186): date of birth page ui
1890bb4
@Srinivasan-Ramasamy
docs(PPDSC-2186): ontro section divider ui fix
1d3e431
@Srinivasan-Ramasamy
Merge branch 'main' into docs/PPDSC-2186-patterns-address-dob-pages
76c3cf4
@Srinivasan-Ramasamy
docs(PPDSC-2186): design feedback changes
17d219a
@Srinivasan-Ramasamy
docs(PPDSC-2187): date picker page initial ui
a226472
@Srinivasan-Ramasamy
docs(PPDSC-2187): email address page ui changes
76fe3a6
@Srinivasan-Ramasamy Srinivasan-Ramasamy added docs Improvements or additions to documentation WIP Work in progress labels Jun 24, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2187-patterns-datepicker-emailaddress-pages
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2187-patterns-datepicker-emailaddress-pages/storybook

@Srinivasan-Ramasamy Srinivasan-Ramasamy added the ready for design review Please assist in getting this reviewed label Jun 24, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed WIP Work in progress labels Jun 27, 2022
baburay23
baburay23 previously approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@baburay23 baburay23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for posting the doc site links!

@Srinivasan-Ramasamy
Copy link
Contributor Author

Srinivasan-Ramasamy commented Jun 28, 2022 •
edited
Loading

Thanks @baburay23 and @mstuartf for taking the time to review 👍

mstuartf
mstuartf previously approved these changes Jun 28, 2022
View reviewed changes
baburay23
baburay23 previously approved these changes Jun 28, 2022
View reviewed changes
@Srinivasan-Ramasamy Srinivasan-Ramasamy dismissed stale reviews from baburay23 and mstuartf via 13fc90d June 28, 2022 14:39
@Srinivasan-Ramasamy Srinivasan-Ramasamy merged commit afa630e into main Jun 28, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy deleted the docs/PPDSC-2187-patterns-datepicker-emailaddress-pages branch June 28, 2022 15:30
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@Srinivasan-Ramasamy
docs(PPDSC-2187): Patterns date picker and email address pages (#237)
59e6cce 
* docs(PPDSC-2187): Patterns date picker and email address pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baburay23 baburay23 baburay23 approved these changes

@mstuartf mstuartf mstuartf approved these changes

@jps jps Awaiting requested review from jps

@Xin00163 Xin00163 Awaiting requested review from Xin00163

@pdimova pdimova Awaiting requested review from pdimova

@mutebg mutebg Awaiting requested review from mutebg

@Vanals Vanals Awaiting requested review from Vanals

@evgenitsn evgenitsn Awaiting requested review from evgenitsn

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Srinivasan-Ramasamy @newskit-engineering @mstuartf @baburay23