Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ppdsc 2208 newskit not working on iframe REVERT CHANGES #227

Merged
merged 7 commits into from
Jun 14, 2022
Merged

Fix/ppdsc 2208 newskit not working on iframe REVERT CHANGES #227

merged 7 commits into from
Jun 14, 2022

Conversation

Vanals
Copy link
Contributor

@Vanals Vanals commented Jun 10, 2022

PPDSC-XXXX

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2208-newskit-not-working-on-iframe
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2208-newskit-not-working-on-iframe/storybook

@Vanals Vanals added the ready for review Please assist in getting this reviewed label Jun 10, 2022
Xin00163
Xin00163 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@Xin00163 Xin00163 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use the revert button in the previous pr if it's the same changes.
Screenshot 2022-06-13 at 13 28 06

@mutebg mutebg merged commit 21e0d7f into main Jun 14, 2022
@mutebg mutebg deleted the fix/PPDSC-2208-newskit-not-working-on-iframe branch June 14, 2022 08:33
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@Vanals @tbradbury @mutebg
Fix/ppdsc 2208 newskit not working on iframe REVERT CHANGES (#227)
9ba1f3b 
* bugfix(PPDSC-2208): removed extra script

* fix(PPDSC-2208): removed unused var

* fix(PPDSC-2208): commented consent cy test

* fix(PPDSC-2208): reverting changes

Co-authored-by: tbradbury <[email protected]>
Co-authored-by: Stoyan Delev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbradbury tbradbury tbradbury approved these changes

@Xin00163 Xin00163 Xin00163 approved these changes

@jps jps Awaiting requested review from jps

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@mutebg mutebg Awaiting requested review from mutebg

@evgenitsn evgenitsn Awaiting requested review from evgenitsn

@Srinivasan-Ramasamy Srinivasan-Ramasamy Awaiting requested review from Srinivasan-Ramasamy

Assignees
No one assigned
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vanals @newskit-engineering @tbradbury @Xin00163 @mutebg