-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PPDSC-2152): single accordion #224
Conversation
You can preview these changes on: |
@Xin00163 run through - looking good. A couple of text colour changes:
Divider/bottom border. When the accordion panel is open can the bottom border of the header be removed so you don’t get a double border? |
Regarding the above, I've managed to line up the state stylePresets of header text and label but since startEnhancer and indicatorIcon cannot inherit the parent stylePreset, I've not managed to have them behave the same way as label. A few things have changed since last review and our discussion:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments should have been addressed. Really appreciate getting all these feedback
* fix(PPDSC-2152): wip * fix(PPDSC-2152): wip * fix(PPDSC-2152): wip * fix(PPDSC-2152): update component structure * feat(PPDSC-2152): added disabled state * feat(PPDSC-2152): a11y * fix(PPDSC-2152): overrides scenario * fix(PPDSC-2152): unit tests * feat(PPDSC-2152): fix:overrides test * fix(PPDSC-2152): e2e tests * fix(PPDSC-2152): clean up * fix(PPDSC-2152): address comments * fix(PPDSC-2152): update storybook * fix(PPDSC-2152): address reviews * fix(PPDSC-2152): address more comments * fix(PPDSC-2152): remove leftover * fix(PPDSC-2152): address more reviews Co-authored-by: agagotowiec <[email protected]> Co-authored-by: Stoyan Delev <[email protected]>
PPDSC-2152
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: