-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PPDSC-2175): layout props 7/7 #223
Conversation
You can preview these changes on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I am just a bit lost on why we have margin: 0
in heading in the first place and if there is any impact.
Got it: It's to reset the browser default margin for <p>
tag: https://stackoverflow.com/questions/20850594/what-is-the-default-margin-value-of-p-tag
* feat(PPDSC-2175): logical props 7/7 * feat(PPDSC-2175): update snapshots * feat(PPDSC-2175): merge 'main' into feat/PPDSC-2175-layout-props-7
PPDSC-2175
What
added
for the following components:
Heading
Paragraph
Unordered List
Video Player
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: