Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2175): layout props 7/7 #223

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2175

What

added

  • margin and padding logical props support
  • storybook scenarios
  • updated docs

for the following components:

  • Heading
  • Paragraph
  • Unordered List
  • Video Player

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the feature This change contains a new feature label Jun 3, 2022
@newskit-engineering
Copy link
Collaborator

@evgenitsn evgenitsn added the ready for review Please assist in getting this reviewed label Jun 6, 2022
Copy link
Contributor

@Xin00163 Xin00163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I am just a bit lost on why we have margin: 0 in heading in the first place and if there is any impact.

Got it: It's to reset the browser default margin for <p> tag: https://stackoverflow.com/questions/20850594/what-is-the-default-margin-value-of-p-tag

@evgenitsn evgenitsn merged commit 49d9af9 into main Jun 8, 2022
@evgenitsn evgenitsn deleted the feat/PPDSC-2175-layout-props-7 branch June 8, 2022 08:32
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* feat(PPDSC-2175): logical props 7/7

* feat(PPDSC-2175): update snapshots

* feat(PPDSC-2175): merge 'main' into feat/PPDSC-2175-layout-props-7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants