Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-1986): layout props 6/7 #213

Merged
merged 5 commits into from
May 31, 2022
Merged

Conversation

evgenitsn
Copy link
Contributor

PPDSC-1986

What

  • added margin and padding logical props support
  • storybook scenario
  • updated docs

for the following components:
Tag
Tabs
Text Field
Title Bar

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the feature This change contains a new feature label May 27, 2022
src/title-bar/styled.tsx Outdated Show resolved Hide resolved
src/text-field/styled.tsx Outdated Show resolved Hide resolved
@newskit-engineering
Copy link
Collaborator

src/title-bar/styled.tsx Outdated Show resolved Hide resolved
src/text-field/styled.tsx Outdated Show resolved Hide resolved
src/tabs/__tests__/__snapshots__/tabs.test.tsx.snap Outdated Show resolved Hide resolved
site/pages/components/title-bar.mdx Show resolved Hide resolved
@evgenitsn evgenitsn added the ready for review Please assist in getting this reviewed label May 27, 2022
@evgenitsn evgenitsn requested a review from mstuartf May 31, 2022 06:08
@evgenitsn evgenitsn merged commit d932bda into main May 31, 2022
@evgenitsn evgenitsn deleted the feat/PPDSC-1986-layout-props-6 branch May 31, 2022 14:36
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* feat(PPDSC-1986): layout props 6/7

* feat(PPDSC-1986): addressing comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants