Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2096): Update with new tokens and states #210

Merged
merged 9 commits into from
May 31, 2022
Merged

docs(PPDSC-2096): Update with new tokens and states #210

merged 9 commits into from
May 31, 2022

Conversation

Srinivasan-Ramasamy
Copy link
Contributor

@Srinivasan-Ramasamy Srinivasan-Ramasamy commented May 26, 2022 •
edited
Loading

PPDSC-2096

What

  1. Updated with the new tokens and states in folllowing doc pages:
    a) Colours
    b) Style Presets
    c) Transition Presets

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Srinivasan-Ramasamy Srinivasan-Ramasamy added docs Improvements or additions to documentation WIP Work in progress labels May 26, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2096-update-tokens-states
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2096-update-tokens-states/storybook

@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for design review Please assist in getting this reviewed ready for review Please assist in getting this reviewed and removed WIP Work in progress ready for design review Please assist in getting this reviewed labels May 27, 2022
evgenitsn
evgenitsn approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@evgenitsn evgenitsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Srinivasan-Ramasamy
Copy link
Contributor Author

Thanks @baburay23 , @evgenitsn for reviewing the code 👍

@Srinivasan-Ramasamy Srinivasan-Ramasamy merged commit f7d2d32 into main May 31, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy deleted the docs/PPDSC-2096-update-tokens-states branch May 31, 2022 06:12
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@Srinivasan-Ramasamy
docs(PPDSC-2096): Update with new tokens and states (#210)
fce3055 
* docs(PPDSC-2096): Update with new tokens and states.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenitsn evgenitsn evgenitsn approved these changes

@baburay23 baburay23 baburay23 approved these changes

@jps jps Awaiting requested review from jps

@Xin00163 Xin00163 Awaiting requested review from Xin00163

@pdimova pdimova Awaiting requested review from pdimova

@mutebg mutebg Awaiting requested review from mutebg

@Vanals Vanals Awaiting requested review from Vanals

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Srinivasan-Ramasamy @newskit-engineering @evgenitsn @baburay23