Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2150): Structured list page #207

Merged
merged 13 commits into from
May 27, 2022

Conversation

Srinivasan-Ramasamy
Copy link
Contributor

PPDSC-2150

What

  1. Structured list page

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Srinivasan-Ramasamy Srinivasan-Ramasamy added docs Improvements or additions to documentation WIP Work in progress labels May 24, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for design review Please assist in getting this reviewed and removed WIP Work in progress labels May 24, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels May 25, 2022
@Srinivasan-Ramasamy
Copy link
Contributor Author

Thanks @baburay23 , @mstuartf for reviewing the code 👍

@Srinivasan-Ramasamy Srinivasan-Ramasamy merged commit 4eef6f9 into main May 27, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy deleted the docs/PPDSC-2150-structured-list-page branch May 27, 2022 05:13
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants