Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2123): add link to the Handoff guide for engineers to the site #203

Merged
merged 3 commits into from
May 19, 2022

Conversation

tbradbury
Copy link
Contributor

PPDSC-2123

What

  1. Handoff guide for engineers missing from the site
  2. added handoff guide for engineers to engineering overview section

Screenshot 2022-05-18 at 2 53 09 pm

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the feature This change contains a new feature label May 18, 2022
@newskit-engineering
Copy link
Collaborator

@tbradbury tbradbury added the ready for review Please assist in getting this reviewed label May 18, 2022
@tbradbury tbradbury merged commit c200809 into main May 19, 2022
@tbradbury tbradbury deleted the feat/PPDSC-2132-handoff-guide branch May 19, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants