Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2139): remove grey background on header comp #201

Merged

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2139

What

Removed grey background on the header components for the docs pages.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

Screenshot 2022-05-16 at 2 32 47 pm

After:

Screenshot 2022-05-16 at 2 32 39 pm

Who should review this PR:

How to test:

Verify if the background on the header elements is not grey anymore.

@github-actions github-actions bot added the docs Improvements or additions to documentation label May 16, 2022
@evgenitsn evgenitsn added the ready for design review Please assist in getting this reviewed label May 16, 2022
Vanals
Vanals previously approved these changes May 17, 2022
mutebg
mutebg previously approved these changes May 18, 2022
@evgenitsn evgenitsn dismissed stale reviews from mutebg and Vanals via 889efba May 18, 2022 08:26
@evgenitsn evgenitsn requested review from mutebg and Vanals May 18, 2022 08:26
@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels May 18, 2022
@evgenitsn evgenitsn merged commit 218ff00 into main May 18, 2022
@evgenitsn evgenitsn deleted the docs/PPDSC-2139-remove-grey-background-on-header-component branch May 18, 2022 13:30
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
* docs(PPDSC-2139): remove grey background on header comp

* docs(PPDSC-2139): updated snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants