Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PPDSC-2067): audio player v2 live functionality stories and tests #200

Merged
merged 6 commits into from
May 16, 2022
Merged

feat(PPDSC-2067): audio player v2 live functionality stories and tests #200

merged 6 commits into from
May 16, 2022

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2067

What

Added Audio Player v2 stories for Live option
Added Audio Player v2 Instrumentation tests
Removed some unnecessary comments

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added the ready for review Please assist in getting this reviewed label May 13, 2022
@github-actions github-actions bot added the feature This change contains a new feature label May 13, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2067-audio-player-v2-live-functionality
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2067-audio-player-v2-live-functionality/storybook

@evgenitsn evgenitsn added the ready for design review Please assist in getting this reviewed label May 13, 2022
mutebg
mutebg reviewed May 13, 2022
View reviewed changes
Copy link
Contributor

@mutebg mutebg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @evgenitsn 👏

src/audio-player-composable/__tests__/audio-player-composable.stories.tsx Show resolved Hide resolved
src/audio-player-composable/__tests__/audio-player-composable.test.tsx Outdated Show resolved Hide resolved
@evgenitsn evgenitsn merged commit 8e9bae5 into main May 16, 2022
@evgenitsn evgenitsn deleted the feat/PPDSC-2067-audio-player-v2-live-functionality branch May 16, 2022 11:56
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@evgenitsn
feat(PPDSC-2067): audio player v2 live functionality stories and tests (
bbc6b84 
#200)

* feat(PPDSC-2067): audio player v2 live functionality stories and tests

* feat(PPDSC-2067): added live flag as a sub-component example

* feat(PPDSC-2067): update live stream url and fix typo

* feat(PPDSC-2067): update live stories layout

* feat(PPDSC-2067): fix mobile view live element position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xin00163 Xin00163 Xin00163 approved these changes

@mutebg mutebg mutebg approved these changes

@jps jps Awaiting requested review from jps

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@Vanals Vanals Awaiting requested review from Vanals

@Srinivasan-Ramasamy Srinivasan-Ramasamy Awaiting requested review from Srinivasan-Ramasamy

Assignees
No one assigned
Labels
feature This change contains a new feature ready for design review Please assist in getting this reviewed ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evgenitsn @newskit-engineering @mutebg @Xin00163