Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2160): back to newskit folder #196

Merged
merged 1 commit into from
May 12, 2022

Conversation

Vanals
Copy link
Contributor

@Vanals Vanals commented May 12, 2022

PPDSC-2160

What

I broke the NewsKit package, so I am fixing it.
move back to the main folder, so the publishment can happen correctly and the dist folder can be found.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the fix This change fixes a bug label May 12, 2022
@Vanals Vanals merged commit 09c3588 into main May 12, 2022
@Vanals Vanals deleted the fix/PPDSC-2160-fix-npm-publish-release branch May 12, 2022 12:43
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants