Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-1976): Media list fix #179

Merged
merged 7 commits into from
May 9, 2022

Conversation

Srinivasan-Ramasamy
Copy link
Contributor

PPDSC-1976

What

  1. MediaList component media should have borderRadius defaults all the corners across the application.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Srinivasan-Ramasamy Srinivasan-Ramasamy added enhancement New feature or request docs Improvements or additions to documentation WIP Work in progress labels Apr 28, 2022
@newskit-engineering
Copy link
Collaborator

@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for design review Please assist in getting this reviewed ready for review Please assist in getting this reviewed and removed WIP Work in progress ready for design review Please assist in getting this reviewed labels Apr 28, 2022
@Srinivasan-Ramasamy
Copy link
Contributor Author

Thanks @tbradbury for reviewing the code 👍

@@ -43,6 +44,9 @@ export const StyledCardContainerMedia = styled.div<
box-sizing: border-box;
display: block;
position: relative;
svg {
${getBorderCssFromTheme('borderRadius', 'borderRadiusRounded010')};
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When should we apply stying directly like this instead of in the style presets for the component?

I'm still trying to wrap my head around the various ways we handle styling!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I guess we do not support svg inside style presets atm?
also not sure if we could add it as nested object in the base? @pdimova

Copy link
Contributor Author

@Srinivasan-Ramasamy Srinivasan-Ramasamy May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mstuartf and @Vanals Thank you for your time for giving valuable feedback.

This style changes has to be updated nested SVG. I was also initialy thinking the same, but after reffered some of the component styles files doubt is cleared and for the consistency updated the same way which those component follows. For example Toast and Flag component has the same nested structure in their styles files.

But, still please suggest me if we need to do any changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 If this is a pattern that we follow elsewhere then it's fine for me. But I would be interested to understand why it doesn't work using defaults / style presets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok @mstuartf, thanks.

@Srinivasan-Ramasamy Srinivasan-Ramasamy merged commit 1d2e54b into main May 9, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy deleted the docs/PPDSC-1976-medialist-fix branch May 9, 2022 09:24
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement New feature or request ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants