Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2075): Button page #175

Merged
merged 27 commits into from
May 5, 2022
Merged

Conversation

Srinivasan-Ramasamy
Copy link
Contributor

@Srinivasan-Ramasamy Srinivasan-Ramasamy commented Apr 22, 2022

PPDSC-2075

What

  1. Button page UI as per the figma design.
  2. Anatomy component dynamic tabs struction logic created.
  3. Radio Button page illustrations changes as per design team CR.
  4. Checkbox page illustrations changes as per design team CR.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Srinivasan-Ramasamy Srinivasan-Ramasamy added docs Improvements or additions to documentation WIP Work in progress labels Apr 22, 2022
@newskit-engineering
Copy link
Collaborator

@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for design review Please assist in getting this reviewed and removed WIP Work in progress labels Apr 26, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Apr 27, 2022
tbradbury
tbradbury previously approved these changes Apr 28, 2022
@Srinivasan-Ramasamy
Copy link
Contributor Author

Thanks @tbradbury for reviewing the code 👍

baburay23
baburay23 previously approved these changes May 5, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy dismissed stale reviews from baburay23 and tbradbury via 3730ee7 May 5, 2022 10:36
@Srinivasan-Ramasamy Srinivasan-Ramasamy merged commit 494336e into main May 5, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy deleted the docs/PPDSC-2075-button-page branch May 5, 2022 11:14
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
docs(PPDSC-2075): Button component page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants