Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2106): correct minimum supported node version #172

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

mstuartf
Copy link
Contributor

PPDSC-1206

What

  1. Background: Some tests (e.g. src/instrumentation/tests/analytics-instrumentation.test.tsx) make assertions on error messages, which depend on the node version being used. We need to make sure the correct version for the tests to pass is specified in the package.json and README.
  2. Set minimum supported node version in package.json and README to 16.9.1.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

How to test:

  • Switch to minimum supported node version and run yarn test locally .

Some tests (e.g. src/instrumentation/_tests_/analytics-instrumentation.test.tsx) make assertions on error messages, which depend on the node version being used. Make sure the correct version for the tests to pass is specified.
@github-actions github-actions bot added the fix This change fixes a bug label Apr 20, 2022
@mstuartf mstuartf added ready for review Please assist in getting this reviewed and removed ready for review Please assist in getting this reviewed labels Apr 20, 2022
@mstuartf mstuartf merged commit 9cb3e0c into main Apr 21, 2022
@mstuartf mstuartf deleted the fix/PPDSC-2106-correct-minimum-node-version branch April 21, 2022 08:10
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
…imum-node-version

fix(PPDSC-2106): correct minimum supported node version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants