Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2104): increase next version to >12.1.1 #170

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

mstuartf
Copy link
Contributor

PPDSC-2104

What

  1. Background: package.json for local next app being generated in the wrong location after upgrading to 12.1.
  2. Increase next version to 12.1.1, which includes a fix for this behaviour.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

includes a fix to prevent build package.json being generated in the wrong location
@github-actions github-actions bot added the fix This change fixes a bug label Apr 19, 2022
@mstuartf mstuartf marked this pull request as ready for review April 19, 2022 15:44
@mstuartf mstuartf merged commit d46b1df into main Apr 20, 2022
@mstuartf mstuartf deleted the fix/PPDSC-2104-prevent-untracked-next-package-json branch April 20, 2022 10:36
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
…racked-next-package-json

fix(PPDSC-2104): increase next version to >12.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants