chore(PPDSC-2079): update axe-core and fix any errors #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenitsn
requested review from
jps,
Xin00163,
pdimova,
baburay23,
mutebg,
Vanals and
Srinivasan-Ramasamy
as code owners
evgenitsn
added
fix
evgenitsn
commented
Apr 19, 2022
|
You can preview these changes on: |
Srinivasan-Ramasamy
previously approved these changes
Apr 20, 2022
mutebg
previously approved these changes
Apr 20, 2022
Vanals
suggested changes
Apr 20, 2022
Vanals
previously approved these changes
Apr 20, 2022
evgenitsn
dismissed stale reviews from Vanals, mutebg, and Srinivasan-Ramasamy
via
1069345
Vanals
approved these changes
Apr 20, 2022
Srinivasan-Ramasamy
approved these changes
Apr 20, 2022
mutebg
approved these changes
Apr 21, 2022
evgenitsn
deleted the
chore/PPDSC-2079-update-axe-core-and-fix-any-errors
branch
Xin00163
pushed a commit
that referenced
this pull request
Oct 17, 2022
* chore(PPDSC-2079): update axe-core and fix any errors * chore(PPDSC-2079): removed unnecessary aria values from thumb * chore(PPDSC-2079): updated snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPDSC-2079
What
Our
axe-coreandcypress-axeversions were not up to date, so I've updated them and cleared all new a11y errors.I have done:
I have tested manually:
How to test:
Run
yarn e2e:buildthenyarn e2e:compsand check if all tests pass (but that should be handled by circleci either way).